Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSS var conversion to hex for Section & Column Block shadow color #1825

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Add CSS var conversion to hex for Section & Column Block shadow color #1825

merged 3 commits into from
Aug 31, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Aug 23, 2023 •
edited
Loading

Closes #1723

Summary

  • Added color extraction to Section Block & Column Block for Shadow Color from CSS vars when opacity is lower than 100%.
  • Minor fix for Flip Shadow Color: it did not consider the new color when processing.

Screenshots

2023-08-23.11-35-12.mp4

Test instructions

  1. Insert a Section block with one Column Block.
  2. Test the shadow in both blocks, like in the video above.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Aug 23, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Aug 23, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review August 23, 2023 08:43
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 270.78 KB 270.78 KB 0 B (0.00%)
Blocks 1.42 MB 1.42 MB 911 B (0.06%)
CSS 85.28 KB 85.28 KB 0 B (0.00%)
Dashboard 122.49 KB 122.49 KB 0 B (0.00%)
Export Import 83.17 KB 83.17 KB 0 B (0.00%)
Pro 303.27 KB 303.27 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 23, 2023 •
edited
Loading

Plugin build for ae2e5ff is ready 🛎️!

@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 23, 2023 •
edited
Loading

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 91.98 7.98 90.73 0 (60ms) 0 (80ms)
Values above 60ms "0 - 95.38, 1 - 95.18, 2 - 88.18, 3 - 90.91, 4 - 82.87, 5 - 87.17, 6 - 84.14, 7 - 96.40, 8 - 92.34, 9 - 85.27, 10 - 102.61, 11 - 104.69, 12 - 90.86, 13 - 87.79, 14 - 90.73, 15 - 85.61, 16 - 114.92, 17 - 88.97, 18 - 83.58"

@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Aug 23, 2023 that may be closed by this pull request
Box Shadow color doesn't change on Section Columns #1723
Closed
@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel If the opacity is already set to 100% and i'm changing the color, it will be black in frontend. I have to change the opacity when the color is already set in order to properly work. Here is a video with the behaviour https://vertis.d.pr/v/0U2tWu

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Aug 25, 2023
@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel Tested again and the mentioned issue is fixed now, thank you 🚀

@HardeepAsrani HardeepAsrani merged commit c8bd024 into development Aug 31, 2023
12 checks passed
@HardeepAsrani HardeepAsrani deleted the fix/section-shadow-opacity branch August 31, 2023 07:27
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HardeepAsrani HardeepAsrani HardeepAsrani approved these changes

Assignees

@Soare-Robert-Daniel Soare-Robert-Daniel

Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Box Shadow color doesn't change on Section Columns
4 participants
@Soare-Robert-Daniel @pirate-bot @irinelenache @HardeepAsrani